Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Tue, 19 Jul 2016 00:44:20 +0000 (UTC)
From: "Tao Li (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.12987240.1467829401000.67334.1468889060923@Atlassian.JIRA>
In-Reply-To: <JIRA.12987240.1467829401000@Atlassian.JIRA>
References: <JIRA.12987240.1467829401000@Atlassian.JIRA> <JIRA.12987240.1467829401411@arcas>
Subject: [jira] [Comment Edited] (HIVE-14169) Honor --incremental flag only
 if TableOutputFormat is used
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 19 Jul 2016 00:44:27 -0000


    [ https://issues.apache.org/jira/browse/HIVE-14169?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383363#comment-15383363 ] 

Tao Li edited comment on HIVE-14169 at 7/19/16 12:44 AM:
---------------------------------------------------------

Hi Sahil,

2 quick questions:

1. I think the default setting for \-\-incremental is still false with your change, right? If that's true, we still go into the code path of buffered rows if the {{--incremental}} is not specified, which I think is a typical use case.

2. Looks like we always do the incremental rows regardless of the setting for {{--incremental}} for non-table formats. What if the user specifies a non-table format and also {{--incremental=false}}? Do we want to do buffered rows in this case?

Thanks.


was (Author: taoli-hwx):
Hi Sahil,

2 quick questions:

1. I think the default setting for \--incremental is still false with your change, right? If that's true, we still go into the code path of buffered rows if the {{--incremental}} is not specified, which I think is a typical use case.

2. Looks like we always do the incremental rows regardless of the setting for {{--incremental}} for non-table formats. What if the user specifies a non-table format and also {{--incremental=false}}? Do we want to do buffered rows in this case?

Thanks.

> Honor --incremental flag only if TableOutputFormat is used
> ----------------------------------------------------------
>
>                 Key: HIVE-14169
>                 URL: https://issues.apache.org/jira/browse/HIVE-14169
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Beeline
>            Reporter: Sahil Takiar
>            Assignee: Sahil Takiar
>         Attachments: HIVE-14169.1.patch
>
>
> * When Beeline prints out a {{ResultSet}} to stdout it uses the {{BeeLine.print}} method
> * This method takes the {{ResultSet}} from the completed query and uses a specified {{OutputFormat}} to print the rows (by default it uses {{TableOutputFormat}})
> * The {{print}} method also wraps the {{ResultSet}} into a {{Rows}} class (either a {{IncrementalRows}} or a {{BufferedRows}} class)
> The advantage of {{BufferedRows}} is that it can do a global calculation of the column width, however, this is only useful for {{TableOutputFormat}}. So there is no need to buffer all the rows if a different {{OutputFormat}} is used. This JIRA will change the behavior of the {{--incremental}} flag so that it is only honored if {{TableOutputFormat}} is used.


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)