hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-14351) Minor improvement in genUnionPlan method
Date Thu, 28 Jul 2016 09:56:20 GMT

    [ https://issues.apache.org/jira/browse/HIVE-14351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15397336#comment-15397336
] 

Hive QA commented on HIVE-14351:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12820362/HIVE-14351.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 6 failed/errored test(s), 10373 tests executed
*Failed tests:*
{noformat}
TestMsgBusConnection - did not produce a TEST-*.xml file
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_avro_nullable_union
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_dml_12
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_list_bucket_dml_13
org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_subquery_multiinsert
org.apache.hadoop.hive.cli.TestNegativeCliDriver.testNegativeCliDriver_avro_non_nullable_union
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/671/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-MASTER-Build/671/console
Test logs: http://ec2-204-236-174-241.us-west-1.compute.amazonaws.com/logs/PreCommit-HIVE-MASTER-Build-671/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 6 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12820362 - PreCommit-HIVE-MASTER-Build

> Minor improvement in genUnionPlan method
> ----------------------------------------
>
>                 Key: HIVE-14351
>                 URL: https://issues.apache.org/jira/browse/HIVE-14351
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 2.1.0
>            Reporter: Ratandeep Ratti
>            Assignee: Ratandeep Ratti
>         Attachments: HIVE-14351.patch
>
>
> {{org.apache.hadoop.hive.ql.parse.SemanticAnalyzer#genUnionPlan}} method can trip new
users reading the code.
> Specifically on line 8979
> {code}
> HashMap<String, ColumnInfo> leftmap = leftRR.getFieldMap(leftalias);
> HashMap<String, ColumnInfo> rightmap = rightRR.getFieldMap(rightalias);
> {code}
> These column maps are actually LinkedHashMaps and the code relies on this fact  when
iterating the two union branches in order.  
> This was not clear immediately and  left me wondering how is it that traversal order
is consistent.
> I've updated the code with this simple fix.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message