hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Barna Zsombor Klara (JIRA)" <>
Subject [jira] [Updated] (HIVE-14226) Invalid check on an ASTNode#toStringTree in CalcitePlanner
Date Fri, 15 Jul 2016 12:00:23 GMT


Barna Zsombor Klara updated HIVE-14226:
    Attachment: HIVE-14226.patch

I have added the patch with a negative qtest and the change to ParseUtils#containsTokenOfType.
The semantic exception is only thrown when we look for a token in the ASTNode, and is not
thrown for the String#contains check.

> Invalid check on an ASTNode#toStringTree in CalcitePlanner
> ----------------------------------------------------------
>                 Key: HIVE-14226
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Barna Zsombor Klara
>            Priority: Minor
>         Attachments: HIVE-14226.patch
> The patch for HIVE-12590 has modified the string tree representation of an ASTNode, so
that everything except string literals are now lowercase.
> However CalcitePlanner#genSelectLogicalPlan is still checking the occurrence of an uppercase
TOK_FUNCTIONDI constant in the string tree.
> (Line 2997 in CalcitePlanner on master)
> I think this check will never evaluate to true, so we should either be using a lowercase
String, or remove the check if it is unnecessary.

This message was sent by Atlassian JIRA

View raw message