hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-14201) Types: Remove hash-lookup from PrimitiveTypeInfo::getPrimitiveCategory()
Date Mon, 11 Jul 2016 17:17:11 GMT

    [ https://issues.apache.org/jira/browse/HIVE-14201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15371189#comment-15371189
] 

Sergey Shelukhin commented on HIVE-14201:
-----------------------------------------

The hashmap is filled in a static block (via registerType). Would it be better to (also?)
replace it with a switch statement?

> Types: Remove hash-lookup from PrimitiveTypeInfo::getPrimitiveCategory()
> ------------------------------------------------------------------------
>
>                 Key: HIVE-14201
>                 URL: https://issues.apache.org/jira/browse/HIVE-14201
>             Project: Hive
>          Issue Type: Bug
>          Components: Types
>    Affects Versions: 2.2.0
>            Reporter: Gopal V
>            Assignee: Gopal V
>              Labels: Performance
>         Attachments: HIVE-14201.1.patch
>
>
> {code}
>   public PrimitiveCategory getPrimitiveCategory() {
>     return getPrimitiveTypeEntry().primitiveCategory;
>   }
>   public PrimitiveTypeEntry getPrimitiveTypeEntry() {
>     return PrimitiveObjectInspectorUtils.getTypeEntryFromTypeName(typeName);
>   }
>   /**
>    * Get the TypeEntry for the given base type name (int, varchar, etc).
>    */
>   public static PrimitiveTypeEntry getTypeEntryFromTypeName(String typeName) {
>     return typeNameToTypeEntry.get(typeName);
>   }
>   // Base type name to PrimitiveTypeEntry map.
>   private static final Map<String, PrimitiveTypeEntry> typeNameToTypeEntry = new
HashMap<String, PrimitiveTypeEntry>();
> {code}
> Not even a single intern() call there. SMH.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message