hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Owen O'Malley (JIRA)" <>
Subject [jira] [Commented] (HIVE-13974) ORC Schema Evolution doesn't support add columns to non-last STRUCT columns
Date Mon, 18 Jul 2016 23:16:20 GMT


Owen O'Malley commented on HIVE-13974:

* This is looking much better, thanks.
* This still needs comprehensive unit tests.
* The new RecordReaderImpl.isStructCategory() should be replaced with the negation of TypeDescription.Category.isPrimitive().
* The new RecordReaderImpl.primitiveTypeNeedsConversion is the same as TypeDescription.equals()
after HIVE-14242.
* Don't use guava in the ORC module.
* The SchemaEvolution.fake field got left in after debugging.
* Instead of using OrcUtils.getOrcTypes to convert TypeDescription into List<OrcProto.Type>,
use the TypeDescription directly in genIncludedColumns and setSearchArgument.

> ORC Schema Evolution doesn't support add columns to non-last STRUCT columns
> ---------------------------------------------------------------------------
>                 Key: HIVE-13974
>                 URL:
>             Project: Hive
>          Issue Type: Bug
>          Components: Hive, ORC, Transactions
>    Affects Versions: 1.3.0, 2.1.0, 2.2.0
>            Reporter: Matt McCline
>            Assignee: Matt McCline
>            Priority: Blocker
>         Attachments: HIVE-13974.01.patch, HIVE-13974.02.patch, HIVE-13974.03.patch, HIVE-13974.04.patch,
HIVE-13974.05.WIP.patch, HIVE-13974.06.patch, HIVE-13974.07.patch, HIVE-13974.08.patch, HIVE-13974.09.patch,
HIVE-13974.091.patch, HIVE-13974.092.patch, HIVE-13974.093.patch, HIVE-13974.094.patch, HIVE-13974.095.patch,
> Currently, the included columns are based on the fileSchema and not the readerSchema
which doesn't work for adding columns to non-last STRUCT data type columns.

This message was sent by Atlassian JIRA

View raw message