hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt McCline (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HIVE-12826) Vectorization: fix VectorUDAF* suspect isNull checks
Date Fri, 29 Jul 2016 22:12:20 GMT

    [ https://issues.apache.org/jira/browse/HIVE-12826?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15400095#comment-15400095
] 

Matt McCline edited comment on HIVE-12826 at 7/29/16 10:11 PM:
---------------------------------------------------------------

This fix is present in branch-2.1 before tags/release-2.1.0-rc3


was (Author: mmccline):
This fix is present in branch-2.1

> Vectorization: fix VectorUDAF* suspect isNull checks
> ----------------------------------------------------
>
>                 Key: HIVE-12826
>                 URL: https://issues.apache.org/jira/browse/HIVE-12826
>             Project: Hive
>          Issue Type: Bug
>          Components: Vectorization
>    Affects Versions: 1.3.0, 2.0.0, 2.1.0
>            Reporter: Gopal V
>            Assignee: Gopal V
>             Fix For: 2.0.0
>
>         Attachments: HIVE-12826.1.patch
>
>
> for isRepeating=true, checking isNull[selected[i]] might return incorrect results (without
a heavy array fill of isNull).
> VectorUDAFSum/Min/Max/Avg and SumDecimal impls need to be reviewed for this pattern.
> {code}
>     private void iterateHasNullsRepeatingSelectionWithAggregationSelection(
>       VectorAggregationBufferRow[] aggregationBufferSets,
>       int aggregateIndex,
>       <ValueType> value,
>       int batchSize,
>       int[] selection,
>       boolean[] isNull) {
>       
>       for (int i=0; i < batchSize; ++i) {
>         if (!isNull[selection[i]]) {
>           Aggregation myagg = getCurrentAggregationBuffer(
>             aggregationBufferSets, 
>             aggregateIndex,
>             i);
>           myagg.sumValue(value);
>         }
>       }
>     }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message