hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Zoltan Haindrich (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HIVE-12244) Refactoring code for avoiding of comparison of Strings and do comparison on Path
Date Thu, 14 Jul 2016 08:29:21 GMT

    [ https://issues.apache.org/jira/browse/HIVE-12244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15376556#comment-15376556
] 

Zoltan Haindrich edited comment on HIVE-12244 at 7/14/16 8:29 AM:
------------------------------------------------------------------

[~alina.abramova] I hope you don't mind...but i've started working on this; because it looks
like it get stuck...this refactor can help stabilize/prevent path related issues.

i've redone this ticket using microcommits to help me zero in on test failures....

i've tried to keep in mind to make a smaller change...but all these methods are connected...and
leaving a few a live would require the temporary refactoring helpers to be added to the codebase
- which i wanted to avoid.

I hope the tests will run without major...my last test run was i think acceptable.

While I was doing this refactor I think i've fixed at least 1 bug - i'm not sure that there
is a use case for which it could happen...should i separate these changes from the refactor?

To keep this patch smaller; and pass with the tests i was forced to keep backward compatible
getters for the Explain subsystem, i will look into that after this patch gets in.



was (Author: kgyrtkirk):
i've redone this ticket using microcommits to help me zero in on test failures....

i've tried to keep in mind to make a smaller change...but all these methods are connected...and
leaving a few a live would require the temporary refactoring helpers to be added to the codebase
- which i wanted to avoid.

I hope the tests will run without major...my last test run was i think acceptable.

While I was doing this refactor I think i've fixed at least 1 bug - i'm not sure that there
is a use case for which it could happen...should i separate these changes from the refactor?

To keep this patch smaller; and pass with the tests i was forced to keep backward compatible
getters for the Explain subsystem, i will look into that after this patch gets in.


> Refactoring code for avoiding of comparison of Strings and do comparison on Path
> --------------------------------------------------------------------------------
>
>                 Key: HIVE-12244
>                 URL: https://issues.apache.org/jira/browse/HIVE-12244
>             Project: Hive
>          Issue Type: Improvement
>          Components: Hive
>    Affects Versions: 0.13.0, 0.14.0, 1.0.0, 1.2.1
>            Reporter: Alina Abramova
>            Assignee: Zoltan Haindrich
>            Priority: Minor
>              Labels: patch
>             Fix For: 1.2.1
>
>         Attachments: HIVE-12244.1.patch, HIVE-12244.10.patch, HIVE-12244.2.patch, HIVE-12244.3.patch,
HIVE-12244.4.patch, HIVE-12244.5.patch, HIVE-12244.6.patch, HIVE-12244.7.patch, HIVE-12244.8.patch,
HIVE-12244.8.patch, HIVE-12244.9.patch
>
>
> In Hive often String is used for representation path and it causes new issues.
> We need to compare it with equals() but comparing Strings often is not right in terms
comparing paths .
> I think if we use Path from org.apache.hadoop.fs we will avoid new problems in future.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message