hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Thejas M Nair (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-7224) Set incremental printing to true by default in Beeline
Date Tue, 05 Jul 2016 20:37:11 GMT

    [ https://issues.apache.org/jira/browse/HIVE-7224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15363180#comment-15363180
] 

Thejas M Nair commented on HIVE-7224:
-------------------------------------

bq. I think a better approach for the IncrementalRows class would be to instead buffer 1000
rows at a time (by default, this value can be configurable), this way it can optimally set
the column width for each set of 1000 rows.
I think it is better to keep the column width to be consistent across all rows in the output,
rather than adjust it every 1000 rows. The purpose of using optimal display size is primarily
to make it easier to read. If we change the column width periodically, it doesn't help with
that. Also, if there is some application that assumes the column width remains the same across
rows, that might break. 

ie, beeline could buffer only the first 1000 rows and use that to determine the optimal column
width, and then output the rest unbuffered. Not having to buffer the remaining rows could
also be better for performance.



> Set incremental printing to true by default in Beeline
> ------------------------------------------------------
>
>                 Key: HIVE-7224
>                 URL: https://issues.apache.org/jira/browse/HIVE-7224
>             Project: Hive
>          Issue Type: Bug
>          Components: Beeline, Clients, JDBC
>    Affects Versions: 0.13.0, 1.0.0, 1.2.0, 1.1.0
>            Reporter: Vaibhav Gumashta
>            Assignee: Sahil Takiar
>         Attachments: HIVE-7224.1.patch, HIVE-7224.2.patch, HIVE-7224.2.patch, HIVE-7224.3.patch
>
>
> See HIVE-7221.
> By default beeline tries to buffer the entire output relation before printing it on stdout.
This can cause OOM when the output relation is large. However, beeline has the option of incremental
prints. We should keep that as the default.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message