Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 68083200B16 for ; Mon, 20 Jun 2016 19:21:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 66C3B160A65; Mon, 20 Jun 2016 17:21:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E0099160A66 for ; Mon, 20 Jun 2016 19:21:06 +0200 (CEST) Received: (qmail 76768 invoked by uid 500); 20 Jun 2016 17:21:05 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 76671 invoked by uid 99); 20 Jun 2016 17:21:05 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 20 Jun 2016 17:21:05 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 619F12C1F6E for ; Mon, 20 Jun 2016 17:21:05 +0000 (UTC) Date: Mon, 20 Jun 2016 17:21:05 +0000 (UTC) From: "Vihang Karajgaonkar (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-14048) patch for HIVE-4570 removes protected fields which can break dependencies MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Mon, 20 Jun 2016 17:21:07 -0000 [ https://issues.apache.org/jira/browse/HIVE-14048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15339953#comment-15339953 ] Vihang Karajgaonkar commented on HIVE-14048: -------------------------------------------- Thanks [~ashutoshc] for clarification. Closing this as per your comment above. > patch for HIVE-4570 removes protected fields which can break dependencies > ------------------------------------------------------------------------- > > Key: HIVE-14048 > URL: https://issues.apache.org/jira/browse/HIVE-14048 > Project: Hive > Issue Type: Bug > Reporter: Vihang Karajgaonkar > Assignee: Vihang Karajgaonkar > Priority: Critical > > The patch for HIVE-4570 removes protected fields like initialized, isDone, started etc and created a TaskState enum to represent these variables. Since these fields which were removed were marked protected, class which can extend Task.java (or DDLTask.java) will fail to compile once they get this patch. > The protected fields should probably be marked deprecated instead of removing them directly since it could break outside dependencies. -- This message was sent by Atlassian JIRA (v6.3.4#6332)