Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 20D81200B13 for ; Wed, 15 Jun 2016 10:57:11 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 1DD2B160A5D; Wed, 15 Jun 2016 08:57:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 6C9AD160A4C for ; Wed, 15 Jun 2016 10:57:10 +0200 (CEST) Received: (qmail 39058 invoked by uid 500); 15 Jun 2016 08:57:09 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 39041 invoked by uid 99); 15 Jun 2016 08:57:09 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Jun 2016 08:57:09 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 7DEC52C033A for ; Wed, 15 Jun 2016 08:57:09 +0000 (UTC) Date: Wed, 15 Jun 2016 08:57:09 +0000 (UTC) From: "Matt McCline (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Comment Edited] (HIVE-13648) ORC Schema Evolution doesn't support same type conversion for VARCHAR, CHAR, or DECIMAL when maxLength or precision/scale is different MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Wed, 15 Jun 2016 08:57:11 -0000 [ https://issues.apache.org/jira/browse/HIVE-13648?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15331407#comment-15331407 ] Matt McCline edited comment on HIVE-13648 at 6/15/16 8:56 AM: -------------------------------------------------------------- [~prasanth_j] Hi Prasanth, Thanks for you review. When converting from CHAR(N) to CHAR(M), the StringGroupFromStringGroupTreeReader class is used. It calls convertStringGroupVectorElement to do any necessary trimming/length adjustment. The Q files have cases for converting to smaller and larger maxLength, etc. Yes, I saw that when the row reader stuff was removed a bunch of not used members / parameters appeared. I had already removed them in the patch that Sergey is currently reviewing. Matt was (Author: mmccline): [~prasanth_j] Hi Prasanth, Thanks for you review. When converting from CHAR(N) to CHAR(M), the StringGroupFromStringGroupTreeReader class is used. It calls convertStringGroupVectorElement to do any necessary trimming/length adjustment. Yes, I saw that when the row reader stuff was removed a bunch of not used members / parameters appeared. I had already removed them in the patch that Sergey is currently reviewing. Matt > ORC Schema Evolution doesn't support same type conversion for VARCHAR, CHAR, or DECIMAL when maxLength or precision/scale is different > -------------------------------------------------------------------------------------------------------------------------------------- > > Key: HIVE-13648 > URL: https://issues.apache.org/jira/browse/HIVE-13648 > Project: Hive > Issue Type: Bug > Reporter: Matt McCline > Assignee: Matt McCline > Priority: Critical > Attachments: HIVE-13648.01.patch, HIVE-13648.02.patch > > > E.g. when a data file is copied in has a VARCHAR maxLength that doesn't match the DDL's maxLength. This error is produced: > {code} > java.io.IOException: ORC does not support type conversion from file type varchar(145) (36) to reader type varchar(114) (36) > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)