hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-13834) Use LinkedHashMap instead of HashMap for LockRequestBuilder to maintain predictable iteration order
Date Wed, 01 Jun 2016 17:17:59 GMT

    [ https://issues.apache.org/jira/browse/HIVE-13834?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15310674#comment-15310674
] 

Wei Zheng commented on HIVE-13834:
----------------------------------

Below is the test failures with age == 1. The only one that's relevant is TestDbTxnManager2.testLocksInSubquery,
which is still due to tests being run on JDK7 thus the unpredictable iteration order.

Test Name
Duration
Age
 org.apache.hadoop.hive.cli.TestCliDriver.testCliDriver_index_auto_mult_tables_compact	23
sec	1
 org.apache.hadoop.hive.ql.lockmgr.TestDbTxnManager2.testLocksInSubquery	5.9 sec	1
 org.apache.hive.minikdc.TestJdbcWithDBTokenStore.testNegativeTokenAuth	0.76 sec	1
 org.apache.hadoop.hive.llap.tezplugins.TestLlapTaskCommunicator.testFinishableStateUpdateFailure
5 sec	1
 org.apache.hadoop.hive.cli.TestMiniTezCliDriver.testCliDriver_bucket3	12 sec	1
 org.apache.hive.jdbc.TestSSL.testSSLConnectionWithURL	33 sec	1
 org.apache.hive.jdbc.TestSSL.testSSLConnectionWithProperty	33 sec	1
 org.apache.hive.jdbc.TestSSL.testConnectionWrongCertCN	45 sec	1
 org.apache.hadoop.hive.llap.daemon.impl.comparator.TestShortestJobFirstComparator.testWaitQueueComparatorWithinDagPriority
5 sec	1

> Use LinkedHashMap instead of HashMap for LockRequestBuilder to maintain predictable iteration
order
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-13834
>                 URL: https://issues.apache.org/jira/browse/HIVE-13834
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 1.3.0, 2.1.0
>            Reporter: Wei Zheng
>            Assignee: Wei Zheng
>         Attachments: HIVE-13834.1.patch
>
>
> In Java 7 it is assumed the iteration order is always the same as the insert order, but
that's not guaranteed. In Java 8 some unit test breaks because of this ordering change. Solution
is to use LinkedHashMap.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message