hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Dere (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-13759) LlapTaskUmbilicalExternalClient should be closed by the record reader
Date Thu, 02 Jun 2016 22:46:59 GMT

    [ https://issues.apache.org/jira/browse/HIVE-13759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15313228#comment-15313228
] 

Jason Dere commented on HIVE-13759:
-----------------------------------

Regarding LlapBaseInputFormat /LlapRowInputFormat.close(), that was supposed to be left to
the application, but as you say this is not standard InputFormat usage .. if you think it
makes more sense to simply close the connection in getSplits() I can make that change and
eliminate the close() call, though this means we lose the support for more complex queries.

I will leave the Closeable interface for the umbilical client since it will cause dependency
problems otherwise since LlapBaseRecordReader does not have visibility to the umbilical client
class.

> LlapTaskUmbilicalExternalClient should be closed by the record reader
> ---------------------------------------------------------------------
>
>                 Key: HIVE-13759
>                 URL: https://issues.apache.org/jira/browse/HIVE-13759
>             Project: Hive
>          Issue Type: Sub-task
>          Components: llap
>            Reporter: Jason Dere
>            Assignee: Jason Dere
>         Attachments: HIVE-13759.1.patch
>
>
> The umbilical external client (and the server socket it creates) doesn't look like it's
getting closed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message