hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sergio Peña (JIRA) <j...@apache.org>
Subject [jira] [Commented] (HIVE-13686) TestRecordReaderImpl is deleting target/tmp causing all the tests after it to fail
Date Wed, 04 May 2016 14:52:12 GMT

    [ https://issues.apache.org/jira/browse/HIVE-13686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15270760#comment-15270760
] 

Sergio Peña commented on HIVE-13686:
------------------------------------

Not sure what happened. The logs were deleted last week. 
I will figure out later what is the problem.

Related to the test failure, I've seen that {{hive-site.xml}} is copied from the root pom.xml
to each module target/tmp directory from this line:
https://github.com/apache/hive/blob/master/pom.xml#L914

I've had some issues before when attempting to use test-sources.jar, and I think the best
practice to keep resources is by storing the hive-site.xml on each module {{src/test/main/resources}}
directory. This way we won't have any issues when some tests delete the temporary directory,
as these resources are copied to target/test-classes. 

However, we still have the issue of the metastore db deleted. We can either fix the ORC test
to avoid deleting temp, or use another temp out of target for metastore.

> TestRecordReaderImpl is deleting target/tmp causing all the tests after it to fail
> ----------------------------------------------------------------------------------
>
>                 Key: HIVE-13686
>                 URL: https://issues.apache.org/jira/browse/HIVE-13686
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Rajat Khandelwal
>
> The issue was introduced in HIVE-12159 (https://github.com/apache/hive/blame/master/ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestRecordReaderImpl.java).
This test deletes target/tmp directory. Because of this, the subsequent tests don't get to
read target/tmp/conf/hive-site.xml, which contains test-specific configurations. Also, target/tmp
has metastore db directory, which also gets deleted causing subsequent tests that use metastore
db to fail too. 
> I'm surprised this issue wasn't caught in pre-commit builds. [~spena] I see that even
the latest pre-commit jobs aren't reporting any errors, while building on local and running
hive-exec test cases causes a bunch of tests to fail. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message