hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hari Sankar Sivarama Subramaniyan (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-13608) We should provide better error message while constraints with duplicate names are created
Date Thu, 12 May 2016 03:07:12 GMT

     [ https://issues.apache.org/jira/browse/HIVE-13608?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Hari Sankar Sivarama Subramaniyan updated HIVE-13608:
-----------------------------------------------------
    Attachment: HIVE-13608.3.patch

After trying out some test cases, It seems in patch#2 the regex was wrong. I tried to rewrite
the regex with negative look ahead/behind. However, given the number of variable characters
between JDOException and java.sql.SQLIntegrityConstraintViolationException, it didnt look
trivial(or rather it looked not possible to incorporate the negative condition of java.sql.SQLIntegrityConstraintViolationException
string as part of the existing regex). I have uploaded the patch#3 with a basic string match
condition which should serve the purpose for now.

> We should provide better error message while constraints with duplicate names are created
> -----------------------------------------------------------------------------------------
>
>                 Key: HIVE-13608
>                 URL: https://issues.apache.org/jira/browse/HIVE-13608
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Hari Sankar Sivarama Subramaniyan
>            Assignee: Hari Sankar Sivarama Subramaniyan
>         Attachments: HIVE-13608.1.patch, HIVE-13608.2.patch, HIVE-13608.3.patch
>
>
> {code}
> PREHOOK: query: create table t1(x int, constraint pk1 primary key (x) disable novalidate)
> PREHOOK: type: CREATETABLE
> PREHOOK: Output: database:default
> PREHOOK: Output: default@t1
> POSTHOOK: query: create table t1(x int, constraint pk1 primary key (x) disable novalidate)
> POSTHOOK: type: CREATETABLE
> POSTHOOK: Output: database:default
> POSTHOOK: Output: default@t1
> PREHOOK: query: create table t2(x int, constraint pk1 primary key (x) disable novalidate)
> PREHOOK: type: CREATETABLE
> PREHOOK: Output: database:default
> PREHOOK: Output: default@t2
> FAILED: Execution Error, return code 1 from org.apache.hadoop.hive.ql.exec.DDLTask. MetaException(message:For
direct MetaStore DB connections, we don't support retries at the client level.)
> {code}
> In the above case, it seems like useful error message is lost. It looks like a  generic
problem with metastore server/client exception handling and message propagation. Seems like
exception parsing logic of RetryingMetaStoreClient::invoke() needs to be updated.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message