hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt McCline (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-13220) Set isNull[i] = false for non-null decimal values in DecimalColumnVector
Date Wed, 25 May 2016 19:07:12 GMT

    [ https://issues.apache.org/jira/browse/HIVE-13220?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15300668#comment-15300668
] 

Matt McCline commented on HIVE-13220:
-------------------------------------

[~jcamachorodriguez] Yes, that is the plan.  Although I have a lot on my plate (including
the LEFT SEMIJOIN issue we talked about and I haven't circled back to).

> Set isNull[i] = false for non-null decimal values in DecimalColumnVector
> ------------------------------------------------------------------------
>
>                 Key: HIVE-13220
>                 URL: https://issues.apache.org/jira/browse/HIVE-13220
>             Project: Hive
>          Issue Type: Bug
>    Affects Versions: 2.1.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Matt McCline
>
> When fixing HIVE-13083 noticed that for non-null decimal values, set function does not
update the isNull state (isNull[i] should be set to false). Updating this state in DecimalColumnVector
breaks all decimal vector filter expressions as the filter expression can change state on
it's own.
> {code}
>         System.arraycopy(inputIsNull, 0, outputIsNull, 0, n);
>         for(int i = 0; i != n; i++) {
>           // The following may override a "false" null setting if an error or overflow
occurs.
>           DecimalUtil.addChecked(i, vector[i], value, outputColVector);
>         }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message