Return-Path: X-Original-To: apmail-hive-issues-archive@minotaur.apache.org Delivered-To: apmail-hive-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4B78E19786 for ; Tue, 5 Apr 2016 10:39:26 +0000 (UTC) Received: (qmail 12862 invoked by uid 500); 5 Apr 2016 10:39:26 -0000 Delivered-To: apmail-hive-issues-archive@hive.apache.org Received: (qmail 12698 invoked by uid 500); 5 Apr 2016 10:39:25 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 12663 invoked by uid 99); 5 Apr 2016 10:39:25 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 05 Apr 2016 10:39:25 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 963342C1F62 for ; Tue, 5 Apr 2016 10:39:25 +0000 (UTC) Date: Tue, 5 Apr 2016 10:39:25 +0000 (UTC) From: "Rajat Khandelwal (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-13415) Decouple Sessions from thrift binary transport MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-13415?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rajat Khandelwal updated HIVE-13415: ------------------------------------ Attachment: HIVE-13415.01.patch > Decouple Sessions from thrift binary transport > ---------------------------------------------- > > Key: HIVE-13415 > URL: https://issues.apache.org/jira/browse/HIVE-13415 > Project: Hive > Issue Type: Bug > Affects Versions: 2.0.0 > Reporter: Rajat Khandelwal > Assignee: Rajat Khandelwal > Attachments: HIVE-13415.01.patch > > > Current behaviour is: > * Open a thrift binary transport > * create a session > * close the transport > Then the session gets closed. Consequently, all the operations running in the session also get killed. > Whereas, if you open an HTTP transport, and close, the enclosing sessions are not closed. > This seems like a bad design, having transport and sessions tightly coupled. I'd like to fix this. > The issue that introduced it is [HIVE-9601|https://github.com/apache/hive/commit/48bea00c48853459af64b4ca9bfdc3e821c4ed82] Relevant discussions at [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223546&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223546], [here|https://issues.apache.org/jira/browse/HIVE-11485?focusedCommentId=15223827&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-15223827] and mentioned links on those comments. > Another thing that seems like a slightly bad design is this line of code in ThriftBinaryCLIService: > {noformat} > server.setServerEventHandler(serverEventHandler); > {noformat} > Whereas serverEventHandler is defined by the base class, with no users except one sub-class(ThriftBinaryCLIService), violating the separation of concerns. -- This message was sent by Atlassian JIRA (v6.3.4#6332)