hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hari Sankar Sivarama Subramaniyan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-13615) nomore_ambiguous_table_col.q is failing on master
Date Fri, 29 Apr 2016 22:19:13 GMT

    [ https://issues.apache.org/jira/browse/HIVE-13615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15264872#comment-15264872
] 

Hari Sankar Sivarama Subramaniyan commented on HIVE-13615:
----------------------------------------------------------

[~ashutoshc]
Reason for the following:
{code}
In addition to that error message has changed for -ve test cases of =nonkey_groupby.q,subquery_shared_alias.q,clustern3.q,clustern4.q,udtf_not_supported1.q,selectDistinctStarNeg_2.q
We are losing line number and char position in error message.
{code}

Its because of the below line :
{code}
nonReserved -> Identifier[$nonReserved.text]
{code}

The above line generates the following code via ANTLR.
{code}
                    // 617:19: -> Identifier[$nonReserved.text]
                    {
                        adaptor.addChild(root_0, 
                        (CommonTree)adaptor.create(Identifier, (nonReserved277!=null?input.toString(nonReserved277.start,nonReserved277.stop):null))
                        );

                    }
{code}

The problem here is that it creates a new Identifier object at the expense of losing the nonReserved277
token information such as start /end index, line number, etc.

The fix would be to change the line to below:

{code}
nonReserved -> Identifier[$nonReserved.start]
{code}

This would prevent losing any valuable token information when the keyword input is transformed
to an identifier token.


> nomore_ambiguous_table_col.q is failing on master
> -------------------------------------------------
>
>                 Key: HIVE-13615
>                 URL: https://issues.apache.org/jira/browse/HIVE-13615
>             Project: Hive
>          Issue Type: Test
>          Components: Parser
>    Affects Versions: 2.1.0
>            Reporter: Ashutosh Chauhan
>            Assignee: Hari Sankar Sivarama Subramaniyan
>         Attachments: HIVE-13615.1.patch
>
>
> Fails with:
> FAILED: ParseException line 3:9 cannot recognize input near 'src' 'key' 'INSERT' in from
source 0



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message