hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alan Gates (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-13560) Adding Omid as connection manager for HBase Metastore
Date Tue, 26 Apr 2016 23:56:12 GMT

    [ https://issues.apache.org/jira/browse/HIVE-13560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15259212#comment-15259212
] 

Alan Gates commented on HIVE-13560:
-----------------------------------

In conf/tez/hive-site.xml did you mean to stomp the hive.orc.splits.ms.footer.cache.enabled
value?

Why take out the option to test Tephra, since we haven't taken out the Tephra connector?

HBaseStore.java, line 451, why did you change the catch from IOException to Exception?  I
can't see any other changes in the code that should require this.

I don't understand why you removed the transactions from getPartitionsByExpr.

I think removing the transactions around the get/putFileMetadata is fine, but we should explicitly
comment that these operations are outside of the transactions and why.

It's not clear to me that you need OmidHBaseConnection.transaction to be a thread local variable.
 HBaseReadWrite is already a thread local in HBaseStore, so you should be guaranteed that
there's an OmidHBaseConnection per thread.





> Adding Omid as connection manager for HBase Metastore
> -----------------------------------------------------
>
>                 Key: HIVE-13560
>                 URL: https://issues.apache.org/jira/browse/HIVE-13560
>             Project: Hive
>          Issue Type: Improvement
>          Components: HBase Metastore
>            Reporter: Daniel Dai
>            Assignee: Daniel Dai
>         Attachments: HIVE-13560.1.patch, HIVE-13560.2.patch, HIVE-13560.3.patch
>
>
> Adding Omid as a transaction manager to HBase Metastore. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message