hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-13410) PerfLog metrics scopes not closed if there are exceptions on HS2
Date Sun, 03 Apr 2016 06:59:25 GMT

     [ https://issues.apache.org/jira/browse/HIVE-13410?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Szehon Ho updated HIVE-13410:
-----------------------------
    Attachment: HIVE-13410.2.patch

Thanks a lot for taking a look!  Addressed review comments.

For the first questions, I do check if the scope is closed via 'active_calls' which is incremented
when scope is open and decremented when scope is closed.  I added comments in the test to
try to make that clearer.

For second question, the perf logger is reset at the beginning of every query (Driver.runInternal)
so I think its lifecycle is more tied to a query rather than session, hence I reset the metrics
on it as part of the return of that query.

> PerfLog metrics scopes not closed if there are exceptions on HS2
> ----------------------------------------------------------------
>
>                 Key: HIVE-13410
>                 URL: https://issues.apache.org/jira/browse/HIVE-13410
>             Project: Hive
>          Issue Type: Bug
>          Components: Diagnosability
>    Affects Versions: 2.0.0
>            Reporter: Szehon Ho
>            Assignee: Szehon Ho
>         Attachments: HIVE-13410.2.patch, HIVE-13410.patch
>
>
> If there are errors, the HS2 PerfLog api scopes are not closed.  Then there are sometimes
messages like 'java.io.IOException: Scope named api_parse is not closed, cannot be opened.'
> I had simply forgetting to close the dangling scopes if there is an exception.  Doing
so now.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message