Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Fri, 18 Mar 2016 16:28:33 +0000 (UTC)
From: =?utf-8?Q?Sergio_Pe=C3=B1a_=28JIRA=29?= <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.12951533.1458314423000.61075.1458318513743@Atlassian.JIRA>
In-Reply-To: <JIRA.12951533.1458314423000@Atlassian.JIRA>
References: <JIRA.12951533.1458314423000@Atlassian.JIRA>
 <JIRA.12951533.1458314423822@arcas>
Subject: [jira] [Commented] (HIVE-13311) MetaDataFormatUtils throws NPE when
 HiveDecimal.create is null
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


    [ https://issues.apache.org/jira/browse/HIVE-13311?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1520=
1737#comment-15201737 ]=20

Sergio Pe=C3=B1a commented on HIVE-13311:
------------------------------------

Thanks [~sircodesalot]
+1

> MetaDataFormatUtils throws NPE when HiveDecimal.create is null
> --------------------------------------------------------------
>
>                 Key: HIVE-13311
>                 URL: https://issues.apache.org/jira/browse/HIVE-13311
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Reuben Kuhnert
>            Assignee: Reuben Kuhnert
>            Priority: Minor
>         Attachments: HIVE-13311.01.patch
>
>
> The {{MetadataFormatUtils.convertToString}} functions have guards to vali=
date for when valid is null, however the {{HiveDecimal.create}} can return =
null and will throw exceptions when {{.toString()}} is called.
> {code}
>   private static String convertToString(Decimal val) {
>     if (val =3D=3D null) {
>       return "";
>     }
>     // HERE: Will throw NPE when HiveDecimal.create returns null.
>     return HiveDecimal.create(new BigInteger(val.getUnscaled()), val.getS=
cale()).toString();
>   }
> {code}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)