Return-Path: X-Original-To: apmail-hive-issues-archive@minotaur.apache.org Delivered-To: apmail-hive-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id F3E0A18740 for ; Fri, 18 Mar 2016 08:57:33 +0000 (UTC) Received: (qmail 64058 invoked by uid 500); 18 Mar 2016 08:57:33 -0000 Delivered-To: apmail-hive-issues-archive@hive.apache.org Received: (qmail 64001 invoked by uid 500); 18 Mar 2016 08:57:33 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 63983 invoked by uid 99); 18 Mar 2016 08:57:33 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Mar 2016 08:57:33 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 6E7DA2C14F4 for ; Fri, 18 Mar 2016 08:57:33 +0000 (UTC) Date: Fri, 18 Mar 2016 08:57:33 +0000 (UTC) From: "Gopal V (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (HIVE-13220) Set isNull[i] = false for non-null decimal values in DecimalColumnVector MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-13220?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gopal V updated HIVE-13220: --------------------------- Description: When fixing HIVE-13083 noticed that for non-null decimal values, set function does not update the isNull state (isNull[i] should be set to false). Updating this state in DecimalColumnVector breaks all decimal vector filter expressions as the filter expression can change state on it's own. {code} System.arraycopy(inputIsNull, 0, outputIsNull, 0, n); for(int i = 0; i != n; i++) { // The following may override a "false" null setting if an error or overflow occurs. DecimalUtil.addChecked(i, vector[i], value, outputColVector); } {code} was:When fixing HIVE-13083 noticed that for non-null decimal values, set function does not update the isNull state (isNull[i] should be set to false). Updating this state in DecimalColumnVector breaks all decimal vector filter expressions as the filter expression can change state on it's own. > Set isNull[i] = false for non-null decimal values in DecimalColumnVector > ------------------------------------------------------------------------ > > Key: HIVE-13220 > URL: https://issues.apache.org/jira/browse/HIVE-13220 > Project: Hive > Issue Type: Bug > Affects Versions: 2.1.0 > Reporter: Prasanth Jayachandran > > When fixing HIVE-13083 noticed that for non-null decimal values, set function does not update the isNull state (isNull[i] should be set to false). Updating this state in DecimalColumnVector breaks all decimal vector filter expressions as the filter expression can change state on it's own. > {code} > System.arraycopy(inputIsNull, 0, outputIsNull, 0, n); > for(int i = 0; i != n; i++) { > // The following may override a "false" null setting if an error or overflow occurs. > DecimalUtil.addChecked(i, vector[i], value, outputColVector); > } > {code} -- This message was sent by Atlassian JIRA (v6.3.4#6332)