hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Vikram Dixit K (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HIVE-13286) Query ID is being reused across queries
Date Tue, 15 Mar 2016 18:14:34 GMT

    [ https://issues.apache.org/jira/browse/HIVE-13286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15195836#comment-15195836
] 

Vikram Dixit K edited comment on HIVE-13286 at 3/15/16 6:14 PM:
----------------------------------------------------------------

The issue here is that if we make a change in the incoming configuration, it remains set for
the duration of the session. We need to make sure that the user does not set the query id
configuration because there is a chance of them breaking what a query id is - a unique id
for each query. I think what you really want is something like the HIVE_LOG_TRACE_ID which
could be renamed to something like a HIVE_USER_TRACE_ID - an id that a user can set and trace
which can stay constant until the user decides to change it. You could create a separate configuration
too for the use case you have. I think allowing the user to mess around with the query id
looks like a recipe for bugs. I think we should move the query id to a config that the user
cannot change and just put it in the utilities class for e.g. like INPUT_NAME that mapreduce
used.


was (Author: vikram.dixit):
The issue here is that if we make a change in the incoming configuration, it remains set for
the duration of the session. We need to make sure that the user does not set the query id
configuration because there is a chance of them breaking what a query id is - a unique id
for each query. I think what you really want is something like the HIVE_LOG_TRACE_ID which
could be renamed to something like a HIVE_USER_TRACE_ID - an id that a user can set and trace
which can stay constant until the user decides to change it. You could create a separate configuration
too for the use case you have. I think messing around with the query id looks like a recipe
for bugs. I think we should move the query id to a config that the user cannot change and
just put it in the utilities class for e.g. like INPUT_NAME that mapreduce used.

> Query ID is being reused across queries
> ---------------------------------------
>
>                 Key: HIVE-13286
>                 URL: https://issues.apache.org/jira/browse/HIVE-13286
>             Project: Hive
>          Issue Type: Bug
>          Components: Parser
>    Affects Versions: 2.0.0
>            Reporter: Vikram Dixit K
>            Assignee: Aihua Xu
>            Priority: Critical
>
> [~aihuaxu] I see this commit made via HIVE-11488. I see that query id is being reused
across queries. This defeats the purpose of a query id. I am not sure what the purpose of
the change in that jira is but it breaks the assumption about a query id being unique for
each query. Please take a look into this at the earliest.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message