hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gopal V (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-13255) FloatTreeReader.nextVector is expensive
Date Wed, 30 Mar 2016 06:43:25 GMT

    [ https://issues.apache.org/jira/browse/HIVE-13255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15217509#comment-15217509
] 

Gopal V commented on HIVE-13255:
--------------------------------

LGTM - +1.

bq. in.read(readBuffer, 0, 4);

does this need a check for the return value? 

I know that InStream always returns the asked size, but that's not in the contract of InputStream.

> FloatTreeReader.nextVector is expensive 
> ----------------------------------------
>
>                 Key: HIVE-13255
>                 URL: https://issues.apache.org/jira/browse/HIVE-13255
>             Project: Hive
>          Issue Type: Bug
>          Components: ORC
>    Affects Versions: 2.1.0
>            Reporter: Prasanth Jayachandran
>            Assignee: Prasanth Jayachandran
>         Attachments: HIVE-13255.1.patch, bytecode-size-after.png, bytecode-size-before.png,
float-reader-perf.png, q1-bottleneck.png, q1-warm-perf-map.png
>
>
> Some TPCDS queries on 1TB scale shows FloatTreeReader on profile samples. It is most
likely because of multiple branching and polymorphic dispatch in FloatTreeReader.nextVector()
implementation. See attached image for sampling profile output.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message