hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rajat Khandelwal (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-13179) Allow custom HiveConf to be passed to Authentication Providers
Date Thu, 03 Mar 2016 08:18:18 GMT

    [ https://issues.apache.org/jira/browse/HIVE-13179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15177466#comment-15177466
] 

Rajat Khandelwal commented on HIVE-13179:
-----------------------------------------

After testing on my local, the tests passed. Updating to master and attaching the patch again
so that pre-commit job can run again. 

> Allow custom HiveConf to be passed to Authentication Providers
> --------------------------------------------------------------
>
>                 Key: HIVE-13179
>                 URL: https://issues.apache.org/jira/browse/HIVE-13179
>             Project: Hive
>          Issue Type: Improvement
>            Reporter: Rajat Khandelwal
>            Assignee: Rajat Khandelwal
>         Attachments: HIVE-13179.1.patch, HIVE-13179.patch, HIVE-13179.patch
>
>
> Right now if I want to create an ldap auth provider, I have to create a hive-site.xml,
set endpoints and other relevant properties there, then instantiate `LdapAuthenticationProviderImpl`,
since inside the constructor, a new HiveConf is constructed. 
> A better and more reusable design would be to ask for the conf in the constructor itself.
That will allow an external user to create a HiveConf, set all relevant properties and instantiate
`LdapAuthenticationProviderImpl` with that conf. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message