Return-Path: 
 <issues-return-32412-apmail-hive-issues-archive=hive.apache.org@hive.apache.org>
X-Original-To: apmail-hive-issues-archive@minotaur.apache.org
Delivered-To: apmail-hive-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id D46BA18C4F
	for <apmail-hive-issues-archive@minotaur.apache.org>;
 Wed, 24 Feb 2016 01:46:18 +0000 (UTC)
Received: (qmail 14352 invoked by uid 500); 24 Feb 2016 01:46:18 -0000
Delivered-To: apmail-hive-issues-archive@hive.apache.org
Received: (qmail 14304 invoked by uid 500); 24 Feb 2016 01:46:18 -0000
Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:issues-help@hive.apache.org>
List-Unsubscribe: <mailto:issues-unsubscribe@hive.apache.org>
List-Post: <mailto:issues@hive.apache.org>
List-Id: <issues.hive.apache.org>
Reply-To: dev@hive.apache.org
Delivered-To: mailing list issues@hive.apache.org
Received: (qmail 14246 invoked by uid 99); 24 Feb 2016 01:46:18 -0000
Received: from arcas.apache.org (HELO arcas) (140.211.11.28)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Feb 2016 01:46:18 +0000
Received: from arcas.apache.org (localhost [127.0.0.1])
	by arcas (Postfix) with ESMTP id 280FA2C1F5C
	for <issues@hive.apache.org>; Wed, 24 Feb 2016 01:46:18 +0000 (UTC)
Date: Wed, 24 Feb 2016 01:46:18 +0000 (UTC)
From: "Anthony Hsu (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.12941603.1456277859000.129228.1456278378160@Atlassian.JIRA>
In-Reply-To: <JIRA.12941603.1456277859000@Atlassian.JIRA>
References: <JIRA.12941603.1456277859000@Atlassian.JIRA>
 <JIRA.12941603.1456277859264@arcas>
Subject: [jira] [Updated] (HIVE-13132) Hive should lazily load and cache
 metastore (permanent) functions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/HIVE-13132?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Anthony Hsu updated HIVE-13132:
-------------------------------
    Attachment: HIVE-13132.1.patch

Uploaded patch.

> Hive should lazily load and cache metastore (permanent) functions
> -----------------------------------------------------------------
>
>                 Key: HIVE-13132
>                 URL: https://issues.apache.org/jira/browse/HIVE-13132
>             Project: Hive
>          Issue Type: Improvement
>    Affects Versions: 0.13.1
>            Reporter: Anthony Hsu
>            Assignee: Anthony Hsu
>         Attachments: HIVE-13132.1.patch
>
>
> In Hive 0.13.1, we have noticed that as the number of databases increases, the start-up time of the Hive interactive shell increases. This is because during start-up, all databases are iterated over to fetch the permanent functions to display in the {{SHOW FUNCTIONS}} output.
> {noformat:title=FunctionRegistry.java}
>   private static Set<String> getFunctionNames(boolean searchMetastore) {
>     Set<String> functionNames = mFunctions.keySet();
>     if (searchMetastore) {
>       functionNames = new HashSet<String>(functionNames);
>       try {
>         Hive db = getHive();
>         List<String> dbNames = db.getAllDatabases();
>         for (String dbName : dbNames) {
>           List<String> funcNames = db.getFunctions(dbName, "*");
>           for (String funcName : funcNames) {
>             functionNames.add(FunctionUtils.qualifyFunctionName(funcName, dbName));
>           }
>         }
>       } catch (Exception e) {
>         LOG.error(e);
>         // Continue on, we can still return the functions we've gotten to this point.
>       }
>     }
>     return functionNames;
>   }
> {noformat}
> Instead of eagerly loading all metastore functions, we should only load them the first time {{SHOW FUNCTIONS}} is invoked. We should also cache the results.
> Note that this issue may have been fixed by HIVE-2573, though I haven't verified this.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)