Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Mon, 1 Feb 2016 06:47:39 +0000 (UTC)
From: "Gopal V (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.12935327.1454121664000.261799.1454309259820@Atlassian.JIRA>
In-Reply-To: <JIRA.12935327.1454121664000@Atlassian.JIRA>
References: <JIRA.12935327.1454121664000@Atlassian.JIRA>
 <JIRA.12935327.1454121664739@arcas>
Subject: [jira] [Commented] (HIVE-12968) genNotNullFilterForJoinSourcePlan:
 needs to merge predicates into the multi-AND
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HIVE-12968?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15125846#comment-15125846 ] 

Gopal V commented on HIVE-12968:
--------------------------------

This change seems to be triggering many hidden optimizations.

{code}
ql/src/test/results/clientpositive/spark/spark_dynamic_partition_pruning.q.out            | 2313 +++++++++++++++++++++++++++++++++++++++++++++++++++++++---------------------------------------
 ql/src/test/results/clientpositive/spark/spark_vectorized_dynamic_partition_pruning.q.out | 2515 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++------------------------------------------
{code}

Join orders are changing due to the constant folding.

> genNotNullFilterForJoinSourcePlan: needs to merge predicates into the multi-AND
> -------------------------------------------------------------------------------
>
>                 Key: HIVE-12968
>                 URL: https://issues.apache.org/jira/browse/HIVE-12968
>             Project: Hive
>          Issue Type: Improvement
>          Components: Logical Optimizer
>    Affects Versions: 2.1.0
>            Reporter: Gopal V
>            Assignee: Gopal V
>            Priority: Minor
>         Attachments: HIVE-12968.1.patch
>
>
> {code}
> predicate: ((cbigint is not null and cint is not null) and cint BETWEEN 1000000 AND 3000000) (type: boolean)
> {code}
> does not fold the IS_NULL on cint, because of the structure of the AND clause.
> For example, see {{tez_dynpart_hashjoin_1.q}}


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)