Return-Path: X-Original-To: apmail-hive-issues-archive@minotaur.apache.org Delivered-To: apmail-hive-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 36FB6184E6 for ; Wed, 17 Feb 2016 22:27:19 +0000 (UTC) Received: (qmail 19484 invoked by uid 500); 17 Feb 2016 22:27:18 -0000 Delivered-To: apmail-hive-issues-archive@hive.apache.org Received: (qmail 19408 invoked by uid 500); 17 Feb 2016 22:27:18 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 18978 invoked by uid 99); 17 Feb 2016 22:27:18 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 17 Feb 2016 22:27:18 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 4369A2C1F6C for ; Wed, 17 Feb 2016 22:27:18 +0000 (UTC) Date: Wed, 17 Feb 2016 22:27:18 +0000 (UTC) From: "Aihua Xu (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-12165) wrong result when hive.optimize.sampling.orderby=true with some aggregate functions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-12165?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15151309#comment-15151309 ] Aihua Xu commented on HIVE-12165: --------------------------------- Attached first patch: when there is a groupby operator, we should not use sample optimizer to have multiple reducers which will lead to incorrect result. > wrong result when hive.optimize.sampling.orderby=true with some aggregate functions > ----------------------------------------------------------------------------------- > > Key: HIVE-12165 > URL: https://issues.apache.org/jira/browse/HIVE-12165 > Project: Hive > Issue Type: Bug > Environment: hortonworks 2.3 > Reporter: ErwanMAS > Assignee: Aihua Xu > Priority: Critical > Attachments: HIVE-12165.patch > > > This simple query give wrong result , when , i use the parallel order . > {noformat} > select count(*) , count(distinct dummyint ) , min(dummyint),max(dummyint) from foobar_1M ; > {noformat} > Current wrong result : > {noformat} > c0 c1 c2 c3 > 32740 32740 0 163695 > 113172 113172 163700 729555 > 54088 54088 729560 999995 > {noformat} > Right result : > {noformat} > c0 c1 c2 c3 > 1000000 1000000 0 999999 > {noformat} > The sql script for my test > {noformat} > drop table foobar_1 ; > create table foobar_1 ( dummyint int , dummystr string ) ; > insert into table foobar_1 select count(*),'dummy 0' from foobar_1 ; > drop table foobar_1M ; > create table foobar_1M ( dummyint bigint , dummystr string ) ; > insert overwrite table foobar_1M > select val_int , concat('dummy ',val_int) from > ( select ((((((d_1*10)+d_2)*10+d_3)*10+d_4)*10+d_5)*10+d_6) as val_int from foobar_1 > lateral view outer explode(split("0,1,2,3,4,5,6,7,8,9",",")) tbl_1 as d_1 > lateral view outer explode(split("0,1,2,3,4,5,6,7,8,9",",")) tbl_2 as d_2 > lateral view outer explode(split("0,1,2,3,4,5,6,7,8,9",",")) tbl_3 as d_3 > lateral view outer explode(split("0,1,2,3,4,5,6,7,8,9",",")) tbl_4 as d_4 > lateral view outer explode(split("0,1,2,3,4,5,6,7,8,9",",")) tbl_5 as d_5 > lateral view outer explode(split("0,1,2,3,4,5,6,7,8,9",",")) tbl_6 as d_6 ) as f ; > set hive.optimize.sampling.orderby.number=10000; > set hive.optimize.sampling.orderby.percent=0.1f; > set mapreduce.job.reduces=3 ; > set hive.optimize.sampling.orderby=false; > select count(*) , count(distinct dummyint ) , min(dummyint),max(dummyint) from foobar_1M ; > set hive.optimize.sampling.orderby=true; > select count(*) , count(distinct dummyint ) , min(dummyint),max(dummyint) from foobar_1M ; > {noformat} -- This message was sent by Atlassian JIRA (v6.3.4#6332)