hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-12916) Cleanup metastore to put unnecessary parameters in EnvironmentContext
Date Mon, 25 Jan 2016 23:18:39 GMT

    [ https://issues.apache.org/jira/browse/HIVE-12916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116268#comment-15116268
] 

Sergey Shelukhin commented on HIVE-12916:
-----------------------------------------

Can we keep the old methods for backward compat though?
Ideally, new method should be created with all args being in a request object (and response
object) that are easy to modify in the future.
See e.g. AddPartitionsRequest and add_partitions_req API  - the new API was added to make
it extensible, and all usages of old APIs were replaced inside Hive, while the old APIs are
still preserved for backward compat for external users. Perhaps we can discuss separately
the removal of all old APIs in Hive 2 line, but that should be done in a more systematic manner.

> Cleanup metastore to put unnecessary parameters in EnvironmentContext
> ---------------------------------------------------------------------
>
>                 Key: HIVE-12916
>                 URL: https://issues.apache.org/jira/browse/HIVE-12916
>             Project: Hive
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Pengcheng Xiong
>            Assignee: Pengcheng Xiong
>            Priority: Blocker
>         Attachments: HIVE-12916.01.patch, HIVE-12916.02.patch
>
>
> for example, void alter_table(1:string dbname, 2:string tbl_name, 3:Table new_tbl) and
void alter_table_with_environment_context(1:string dbname, 2:string tbl_name, 3:Table new_tbl,
4:EnvironmentContext environment_context), we plan to keep only the latter one.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message