hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Pengcheng Xiong (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-12916) Cleanup metastore to put unnecessary parameters in EnvironmentContext
Date Mon, 25 Jan 2016 22:51:39 GMT

    [ https://issues.apache.org/jira/browse/HIVE-12916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116231#comment-15116231
] 

Pengcheng Xiong commented on HIVE-12916:
----------------------------------------

[~sershe], right now some configuration parameters, such as deletedata and cascading have
their own functions. It has the following disadvantages: (1) They should be kept in EnvironmentContext,
not as a parameter of the function. This is the design purpose of EnvironmentContext. (2)
Current solution is not good to extend in the future. For example, what if you want to add
another configuration, then are you going to add another function in thrift? Putting all of
them in an EnvironmentContext will be good to extend. 
The clean up that I am proposing is exactly redirect them to on internal call, with EnvironmentContext.


> Cleanup metastore to put unnecessary parameters in EnvironmentContext
> ---------------------------------------------------------------------
>
>                 Key: HIVE-12916
>                 URL: https://issues.apache.org/jira/browse/HIVE-12916
>             Project: Hive
>          Issue Type: Sub-task
>    Affects Versions: 2.0.0
>            Reporter: Pengcheng Xiong
>            Assignee: Pengcheng Xiong
>            Priority: Blocker
>         Attachments: HIVE-12916.01.patch, HIVE-12916.02.patch
>
>
> for example, void alter_table(1:string dbname, 2:string tbl_name, 3:Table new_tbl) and
void alter_table_with_environment_context(1:string dbname, 2:string tbl_name, 3:Table new_tbl,
4:EnvironmentContext environment_context), we plan to keep only the latter one.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message