hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-12758) Parallel compilation: Operator::resetId() is not thread-safe
Date Wed, 06 Jan 2016 00:41:39 GMT

    [ https://issues.apache.org/jira/browse/HIVE-12758?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15084450#comment-15084450
] 

Sergey Shelukhin commented on HIVE-12758:
-----------------------------------------

We need to add a check to ptest that would emit a grumpy cat if threadlocals are added. And
non-capitalized statics.

> Parallel compilation: Operator::resetId() is not thread-safe
> ------------------------------------------------------------
>
>                 Key: HIVE-12758
>                 URL: https://issues.apache.org/jira/browse/HIVE-12758
>             Project: Hive
>          Issue Type: Bug
>          Components: Physical Optimizer
>    Affects Versions: 2.0.0, 2.1.0
>            Reporter: Gopal V
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-12758.patch
>
>
> {code}
>   private static AtomicInteger seqId;
> ...
>   public Operator() {
>     this(String.valueOf(seqId.getAndIncrement()));
>   }
>   public static void resetId() {
>     seqId.set(0);
>   }
> {code}
> Potential race-condition.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message