hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ashutosh Chauhan (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-12645) ConstantPropagateProcCtx.resolve() should verify internal names in addition to alias to match 2 columns from different row schemas
Date Thu, 07 Jan 2016 02:35:39 GMT

    [ https://issues.apache.org/jira/browse/HIVE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15086694#comment-15086694
] 

Ashutosh Chauhan commented on HIVE-12645:
-----------------------------------------

+1 pending tests

> ConstantPropagateProcCtx.resolve() should verify internal names in addition to alias
to match 2 columns from different row schemas 
> -----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-12645
>                 URL: https://issues.apache.org/jira/browse/HIVE-12645
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Hari Sankar Sivarama Subramaniyan
>            Assignee: Hari Sankar Sivarama Subramaniyan
>         Attachments: HIVE-12645.1.patch, HIVE-12645.2.patch, HIVE-12645.3.patch, HIVE-12645.4.patch
>
>
> Currently, it seems that we look to match the ColumnInfo between the parent and the child
rowschemas by calling rci = rs.getColumnInfo(tblAlias, alias) which might be a bit aggressive.
i.e. we will lose opportunity to constant propogate even if the columns are the same but the
alias in the rowschemas do not match. We need to introduce additional checks to see if the
columns can be mapped to constants from parents.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message