hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ryan Blue (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-12195) Unknown zones should cause an error instead of silently failing
Date Mon, 25 Jan 2016 19:07:40 GMT

    [ https://issues.apache.org/jira/browse/HIVE-12195?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15115782#comment-15115782
] 

Ryan Blue commented on HIVE-12195:
----------------------------------

Two of the CI test failures look relevant since they reference {to,from}_utc_timestamp.

Also, the use of an ArrayList to validate the time zone seems inefficient. It looks like this
will iterate through the available zones every time the function is called. What about using
a HashSet in instead?

> Unknown zones should cause an error instead of silently failing
> ---------------------------------------------------------------
>
>                 Key: HIVE-12195
>                 URL: https://issues.apache.org/jira/browse/HIVE-12195
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>            Reporter: Ryan Blue
>            Assignee: Shinichi Yamashita
>         Attachments: HIVE-12195.1.patch
>
>
> Using an unknown time zone with the {{from_utc_timestamp}} or {{to_utc_timetamp}} methods
returns the time un-adjusted instead of throwing an error:
> {code}
> hive> select from_utc_timestamp('2015-04-11 12:24:34.535', 'panda');
> OK
> 2015-04-11 12:24:34.535
> {code}
> This should be an error because users may attempt to adjust to valid but unknown zones,
like PDT or MDT. This would produce incorrect results with no warning or error.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message