Return-Path: X-Original-To: apmail-hive-issues-archive@minotaur.apache.org Delivered-To: apmail-hive-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DF89318244 for ; Fri, 11 Dec 2015 19:15:46 +0000 (UTC) Received: (qmail 18088 invoked by uid 500); 11 Dec 2015 19:15:46 -0000 Delivered-To: apmail-hive-issues-archive@hive.apache.org Received: (qmail 18063 invoked by uid 500); 11 Dec 2015 19:15:46 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 18047 invoked by uid 99); 11 Dec 2015 19:15:46 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Dec 2015 19:15:46 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A20DF2C14DC for ; Fri, 11 Dec 2015 19:15:46 +0000 (UTC) Date: Fri, 11 Dec 2015 19:15:46 +0000 (UTC) From: "Jason Dere (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-12620) Misc improvement to Acid module MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-12620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053389#comment-15053389 ] Jason Dere commented on HIVE-12620: ----------------------------------- +1 > Misc improvement to Acid module > ------------------------------- > > Key: HIVE-12620 > URL: https://issues.apache.org/jira/browse/HIVE-12620 > Project: Hive > Issue Type: Bug > Components: Transactions > Affects Versions: 1.3.0 > Reporter: Eugene Koifman > Assignee: Eugene Koifman > Attachments: HIVE-12620.patch > > > # DbLockManger.unlock() - if this fails (due to no such lock in turn due to timeout) the lock is not removed from DbLockManger internal tracking > # Add logic to DBLockManager to detect if there is attempt to interleave transactions or locks from different statements for read-only auto commit mode > # TxnHandler.checkLock() can use 1 connection instead of 2 > # TxnHandler.timeOutLocks() - refactor so that it can log which locks were expired (simplifies debugging) > # TxnHandler#getTxnIdFromLockId() - include lock id if it's not found > # TxnHandler#checkRetryable() - log exception it saw > # TxnHandler.lock() - throw new MetaException("Couldn't find a lock we just created!"); - include lockid -- This message was sent by Atlassian JIRA (v6.3.4#6332)