hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Gunther Hagleitner (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-12667) Proper fix for HIVE-12473
Date Tue, 15 Dec 2015 21:10:46 GMT

    [ https://issues.apache.org/jira/browse/HIVE-12667?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15058824#comment-15058824
] 

Gunther Hagleitner commented on HIVE-12667:
-------------------------------------------

In dynamic_partition_pruning_2.q it's actually an int. All other tests have defined the part
col as string. String to string doesn't need a special code path, is that what you're suggesting?

> Proper fix for HIVE-12473
> -------------------------
>
>                 Key: HIVE-12667
>                 URL: https://issues.apache.org/jira/browse/HIVE-12667
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Gunther Hagleitner
>            Assignee: Gunther Hagleitner
>         Attachments: HIVE-12667.1.patch
>
>
> HIVE-12473 has added an incorrect comment and also lacks a test case.
> Benefits of this fix:
>    * Does not say: "Probably doesn't work"
>    * Does not use grammar like "subquery columns and such"
>    * Adds test cases, that let you verify the fix
>    * Doesn't rely on certain structure of key expr, just takes the type at compile time
>    * Doesn't require an additional walk of each key expression
>    * Shows the type used in explain



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message