hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Wei Zheng (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-12620) Misc improvement to Acid module
Date Fri, 11 Dec 2015 18:37:10 GMT

    [ https://issues.apache.org/jira/browse/HIVE-12620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15053166#comment-15053166
] 

Wei Zheng commented on HIVE-12620:
----------------------------------

Code looks good to me.

+1 (non-binding)

> Misc improvement to Acid module
> -------------------------------
>
>                 Key: HIVE-12620
>                 URL: https://issues.apache.org/jira/browse/HIVE-12620
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 1.3.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>         Attachments: HIVE-12620.patch
>
>
> # DbLockManger.unlock() - if this fails (due to no such lock in turn due to timeout)
the lock is not removed from DbLockManger internal tracking
> # Add logic to DBLockManager to detect if there is attempt to interleave transactions
or locks from different statements for read-only auto commit mode
> # TxnHandler.checkLock() can use 1 connection instead of 2
> # TxnHandler.timeOutLocks() - refactor so that it can log which locks were expired (simplifies
debugging)
> # TxnHandler#getTxnIdFromLockId() - include lock id if it's not found
> # TxnHandler#checkRetryable() - log exception it saw
> # TxnHandler.lock() - throw new MetaException("Couldn't find a lock we just created!");
- include lockid



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message