Return-Path: X-Original-To: apmail-hive-issues-archive@minotaur.apache.org Delivered-To: apmail-hive-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 15DB31839B for ; Mon, 2 Nov 2015 22:05:28 +0000 (UTC) Received: (qmail 82456 invoked by uid 500); 2 Nov 2015 22:05:28 -0000 Delivered-To: apmail-hive-issues-archive@hive.apache.org Received: (qmail 82388 invoked by uid 500); 2 Nov 2015 22:05:28 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 82319 invoked by uid 99); 2 Nov 2015 22:05:27 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 02 Nov 2015 22:05:27 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id D5C8C2C1F63 for ; Mon, 2 Nov 2015 22:05:27 +0000 (UTC) Date: Mon, 2 Nov 2015 22:05:27 +0000 (UTC) From: "Ashutosh Chauhan (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-12305) CBO: Calcite Operator To Hive Operator (Calcite Return Path): UDAF can not pull up constant expressions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-12305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14986144#comment-14986144 ] Ashutosh Chauhan commented on HIVE-12305: ----------------------------------------- Fix in this patch is a guard against failures, but knowing which expr is constant in GBY's aggregation function arguments could be better done using Metadata provider of Calcite. It will be good to add a #TODO in comment for this. +1 LGTM > CBO: Calcite Operator To Hive Operator (Calcite Return Path): UDAF can not pull up constant expressions > ------------------------------------------------------------------------------------------------------- > > Key: HIVE-12305 > URL: https://issues.apache.org/jira/browse/HIVE-12305 > Project: Hive > Issue Type: Sub-task > Components: CBO > Reporter: Pengcheng Xiong > Assignee: Pengcheng Xiong > Attachments: HIVE-12305.01.patch > > > to repro, run annotate_stats_groupby.q with return path turned on. -- This message was sent by Atlassian JIRA (v6.3.4#6332)