hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene Koifman (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-12353) When Compactor fails it calls CompactionTxnHandler.markedCleaned(). it should not.
Date Thu, 05 Nov 2015 21:39:27 GMT

     [ https://issues.apache.org/jira/browse/HIVE-12353?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Eugene Koifman updated HIVE-12353:
----------------------------------
    Description: 
One of the things that this method does is delete entries from TXN_COMPONENTS for partition
that it was trying to compact.
This causes Aborted transactions in TXNS to become empty according to
CompactionTxnHandler.cleanEmptyAbortedTxns() which means they can now be delete.  

We should extend COMPACTION_QUEUE state with 'f' and 's' (failed, success) states.  We should
also not delete then entry from markedCleaned()
We'll have separate process that cleans 'f' and 's' records after X minutes (or after >
N records for a given partition exist).
This allows SHOW COMPACTIONS to show some history info and how many times compaction failed
on a given partition (subject to retention interval) so that we don't have to call markCleaned()
on Compactor failures at the same time preventing Compactor to constantly getting stuck on
the same bad partition/table.

Ideally we'd want to include END_TIME field.


  was:
One of the things that this method does is delete entries from TXN_COMPONENTS for partition
that it was trying to compact.
This causes Aborted transactions in TXNS to become empty according to
CompactionTxnHandler.cleanEmptyAbortedTxns() which means they can now be delete.  

We should extend COMPACTION_QUEUE state with 'f' and 's' (failed, success) states.  We should
also not delete then entry from markedCleaned()
We'll have separate process that cleans 'f' and 's' records after X minutes (or after >
N records for a given partition exist).
This allows SHOW COMPACTIONS to show some history info and how many times compaction failed
on a given partition (subject to retention interval) so that we don't have to call markCleaned()
on Compactor failures at the same time preventing Compactor to constantly getting stuck on
the same bad partition/table.




> When Compactor fails it calls CompactionTxnHandler.markedCleaned().  it should not.
> -----------------------------------------------------------------------------------
>
>                 Key: HIVE-12353
>                 URL: https://issues.apache.org/jira/browse/HIVE-12353
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 1.0.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>
> One of the things that this method does is delete entries from TXN_COMPONENTS for partition
that it was trying to compact.
> This causes Aborted transactions in TXNS to become empty according to
> CompactionTxnHandler.cleanEmptyAbortedTxns() which means they can now be delete.  
> We should extend COMPACTION_QUEUE state with 'f' and 's' (failed, success) states.  We
should also not delete then entry from markedCleaned()
> We'll have separate process that cleans 'f' and 's' records after X minutes (or after
> N records for a given partition exist).
> This allows SHOW COMPACTIONS to show some history info and how many times compaction
failed on a given partition (subject to retention interval) so that we don't have to call
markCleaned() on Compactor failures at the same time preventing Compactor to constantly getting
stuck on the same bad partition/table.
> Ideally we'd want to include END_TIME field.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message