Return-Path: X-Original-To: apmail-hive-issues-archive@minotaur.apache.org Delivered-To: apmail-hive-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 1BC7C188E0 for ; Sat, 31 Oct 2015 02:09:28 +0000 (UTC) Received: (qmail 54171 invoked by uid 500); 31 Oct 2015 02:09:28 -0000 Delivered-To: apmail-hive-issues-archive@hive.apache.org Received: (qmail 54149 invoked by uid 500); 31 Oct 2015 02:09:27 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 54135 invoked by uid 99); 31 Oct 2015 02:09:27 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 31 Oct 2015 02:09:27 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id BBF9B2C14E1 for ; Sat, 31 Oct 2015 02:09:27 +0000 (UTC) Date: Sat, 31 Oct 2015 02:09:27 +0000 (UTC) From: "Laljo John Pullokkaran (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-12156) expanding view doesn't quote reserved keyword MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-12156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14983745#comment-14983745 ] Laljo John Pullokkaran commented on HIVE-12156: ----------------------------------------------- I looked at the patch. As we discussed: 1. fieldDescMap generation can be moved inside the first loop 2. If we maintain ordered list of fields then we can avoid the while loop. > expanding view doesn't quote reserved keyword > --------------------------------------------- > > Key: HIVE-12156 > URL: https://issues.apache.org/jira/browse/HIVE-12156 > Project: Hive > Issue Type: Bug > Components: Parser > Affects Versions: 1.2.1 > Environment: hadoop 2.7 > hive 1.2.1 > Reporter: Jay Lee > Assignee: Pengcheng Xiong > Attachments: HIVE-12156.01.patch > > > hive> create table testreserved (data struct<`end`:string, id: string>); > OK > Time taken: 0.274 seconds > hive> create view testreservedview as select data.`end` as data_end, data.id as data_id from testreserved; > OK > Time taken: 0.769 seconds > hive> select data.`end` from testreserved; > OK > Time taken: 1.852 seconds > hive> select data_id from testreservedview; > NoViableAltException(98@[]) > at org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.identifier(HiveParser_IdentifiersParser.java:10858) > at org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceFieldExpression(HiveParser_IdentifiersParser.java:6438) > at org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceUnaryPrefixExpression(HiveParser_IdentifiersParser.java:6768) > at org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceUnarySuffixExpression(HiveParser_IdentifiersParser.java:6828) > at org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceBitwiseXorExpression(HiveParser_IdentifiersParser.java:7012) > at org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceStarExpression(HiveParser_IdentifiersParser.java:7172) > at org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedencePlusExpression(HiveParser_IdentifiersParser.java:7332) > at org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceAmpersandExpression(HiveParser_IdentifiersParser.java:7483) > at org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceBitwiseOrExpression(HiveParser_IdentifiersParser.java:7634) > at org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceEqualExpression(HiveParser_IdentifiersParser.java:8164) > at org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceNotExpression(HiveParser_IdentifiersParser.java:9177) > at org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceAndExpression(HiveParser_IdentifiersParser.java:9296) > at org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.precedenceOrExpression(HiveParser_IdentifiersParser.java:9455) > at org.apache.hadoop.hive.ql.parse.HiveParser_IdentifiersParser.expression(HiveParser_IdentifiersParser.java:6105) > at org.apache.hadoop.hive.ql.parse.HiveParser.expression(HiveParser.java:45840) > at org.apache.hadoop.hive.ql.parse.HiveParser_SelectClauseParser.selectItem(HiveParser_SelectClauseParser.java:2907) > at org.apache.hadoop.hive.ql.parse.HiveParser_SelectClauseParser.selectList(HiveParser_SelectClauseParser.java:1373) > at org.apache.hadoop.hive.ql.parse.HiveParser_SelectClauseParser.selectClause(HiveParser_SelectClauseParser.java:1128) > at org.apache.hadoop.hive.ql.parse.HiveParser.selectClause(HiveParser.java:45827) > at org.apache.hadoop.hive.ql.parse.HiveParser.selectStatement(HiveParser.java:41495) > at org.apache.hadoop.hive.ql.parse.HiveParser.regularBody(HiveParser.java:41402) > at org.apache.hadoop.hive.ql.parse.HiveParser.queryStatementExpressionBody(HiveParser.java:40413) > at org.apache.hadoop.hive.ql.parse.HiveParser.queryStatementExpression(HiveParser.java:40283) > at org.apache.hadoop.hive.ql.parse.HiveParser.execStatement(HiveParser.java:1590) > at org.apache.hadoop.hive.ql.parse.HiveParser.statement(HiveParser.java:1109) > at org.apache.hadoop.hive.ql.parse.ParseDriver.parse(ParseDriver.java:202) > ... > FAILED: SemanticException line 1:29 cannot recognize input near 'end' 'as' 'data_end' in expression specification in definition of VIEW testreservedview [ > select `testreserved`.`data`.end as `data_end`, `testreserved`.`data`.id as `data_id` from `test`.`testreserved` > ] used as testreservedview at Line 1:20 > When view is expanded, field should be quote with backquote. -- This message was sent by Atlassian JIRA (v6.3.4#6332)