hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt McCline (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-12090) Dead-code: Vectorized map-join murmur hash is run twice
Date Mon, 12 Oct 2015 08:51:05 GMT

    [ https://issues.apache.org/jira/browse/HIVE-12090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14952821#comment-14952821
] 

Matt McCline commented on HIVE-12090:
-------------------------------------

+1, LGTM

> Dead-code: Vectorized map-join murmur hash is run twice
> -------------------------------------------------------
>
>                 Key: HIVE-12090
>                 URL: https://issues.apache.org/jira/browse/HIVE-12090
>             Project: Hive
>          Issue Type: Bug
>          Components: Vectorization
>    Affects Versions: 1.3.0, 2.0.0
>            Reporter: Gopal V
>            Assignee: Gopal V
>         Attachments: HIVE-12090.1.patch
>
>
> Caught by [~mmccline] during code reviews.
> {code}
>    public JoinUtil.JoinResult setDirect(byte[] bytes, int offset, int length,
>         BytesBytesMultiHashMap.Result hashMapResult) {
>       int keyHash = WriteBuffers.murmurHash(bytes, offset, length);
>       aliasFilter = hashMap.getValueResult(bytes, offset, length, hashMapResult);
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message