hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sergey Shelukhin (JIRA)" <j...@apache.org>
Subject [jira] [Comment Edited] (HIVE-11591) upgrade thrift to 0.9.3 and change generation to use undated annotations
Date Fri, 16 Oct 2015 21:43:06 GMT

    [ https://issues.apache.org/jira/browse/HIVE-11591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14961399#comment-14961399
] 

Sergey Shelukhin edited comment on HIVE-11591 at 10/16/15 9:42 PM:
-------------------------------------------------------------------

The patch. I eyeballed the generated code, the only differences in Java files, other than
the dates being gone, are the removal of Foo.valueOf(bar) when returning things (e.g. return
getBlah() instead of return Long.valueOf(getBlah()))


was (Author: sershe):
The patch. I eyeballed the generated code, the only differences in Java files, other than
the dates being gone, are the removal of Foo.valueOf(bar) when returning things (e.g. return
getBlah() instead of return Long.valueOf(getBlah())

> upgrade thrift to 0.9.3 and change generation to use undated annotations
> ------------------------------------------------------------------------
>
>                 Key: HIVE-11591
>                 URL: https://issues.apache.org/jira/browse/HIVE-11591
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>         Attachments: HIVE-11591.WIP.patch, HIVE-11591.nogen.patch, HIVE-11591.patch
>
>
> Thrift has added class annotations to generated classes; these contain generation date.
Because of this, all the Java thrift files change on every re-gen, even if you only make a
small change that should not affect bazillion files. We should use undated annotations to
avoid this problem.
> This depends on upgrading to Thrift 0.9.3, -which doesn't exist yet-.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message