Return-Path: X-Original-To: apmail-hive-issues-archive@minotaur.apache.org Delivered-To: apmail-hive-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C63E5187B5 for ; Wed, 30 Sep 2015 20:40:15 +0000 (UTC) Received: (qmail 78472 invoked by uid 500); 30 Sep 2015 20:40:04 -0000 Delivered-To: apmail-hive-issues-archive@hive.apache.org Received: (qmail 78289 invoked by uid 500); 30 Sep 2015 20:40:04 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 78206 invoked by uid 99); 30 Sep 2015 20:40:04 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 30 Sep 2015 20:40:04 +0000 Date: Wed, 30 Sep 2015 20:40:04 +0000 (UTC) From: "Eugene Koifman (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-11934) Transaction lock retry logic results in infinite loop MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-11934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938821#comment-14938821 ] Eugene Koifman commented on HIVE-11934: --------------------------------------- yes, I understand. checkRetryable() is the main method that handles some checking itself and delegates some checking to isRetryable(). it should be refactored at some point but the fact is that ORA-8177 is checked for already. This is not the cause of the infinite loop. > Transaction lock retry logic results in infinite loop > ----------------------------------------------------- > > Key: HIVE-11934 > URL: https://issues.apache.org/jira/browse/HIVE-11934 > Project: Hive > Issue Type: Bug > Components: HiveServer2, Transactions > Affects Versions: 1.2.1 > Reporter: Steve Howard > Assignee: Eugene Koifman > Priority: Minor > Attachments: HIVE-11934.patch > > > We reset the deadlock count to 0 every time the lock() method is called in org.apache.hadoop.hive.metastore.txn.TxnHandler, so the ten count is never reached in checkRetryable(). > We should let checkRetryable handle the deadlock count. > public LockResponse lock(LockRequest rqst) > throws NoSuchTxnException, TxnAbortedException, MetaException > { > >>> this.deadlockCnt = 0; <<< > try > { > Connection dbConn = null; > try > { -- This message was sent by Atlassian JIRA (v6.3.4#6332)