Mailing-List: contact issues-help@hive.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@hive.apache.org
Date: Wed, 16 Sep 2015 00:25:46 +0000 (UTC)
From: "Illya Yalovyy (JIRA)" <jira@apache.org>
To: issues@hive.apache.org
Message-ID: <JIRA.12863148.1441910252000.348948.1442363146788@Atlassian.JIRA>
In-Reply-To: <JIRA.12863148.1441910252000@Atlassian.JIRA>
References: <JIRA.12863148.1441910252000@Atlassian.JIRA>
 <JIRA.12863148.1441910252167@arcas>
Subject: [jira] [Commented] (HIVE-11791) Add unit test for HIVE-10122
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HIVE-11791?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14746568#comment-14746568 ] 

Illya Yalovyy commented on HIVE-11791:
--------------------------------------

[~hagleitn] , Could you please review results of my unit tests. In particular:
1. when compactExpr(and(true, null)) it was TRUE before your change. Now it is null. 
2. when compactExpr(or(true, null)) it was NULL, and now it returns TRUE.

These changes in behavior totally make sense, I just want to confirm it was done intentionally and will not have any side effects.
 
Those changes look strange to me:

when compactExpr(and(true, true)) it was TRUE, now it return NULL.
when compactExpr(or(isNull(col1), false)) it was isNull(col1), now it returns NULL 

Also, it would be great if you suggest other test cases for this method.


> Add unit test for HIVE-10122
> ----------------------------
>
>                 Key: HIVE-11791
>                 URL: https://issues.apache.org/jira/browse/HIVE-11791
>             Project: Hive
>          Issue Type: Test
>          Components: Metastore
>    Affects Versions: 1.1.0
>            Reporter: Illya Yalovyy
>            Priority: Minor
>         Attachments: HIVE-11791.patch
>
>
> Unit tests for PartitionPruner.compactExpr()


--
This message was sent by Atlassian JIRA
(v6.3.4#6332)