hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eugene Koifman (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-11934) Transaction lock retry logic results in infinite loop
Date Wed, 30 Sep 2015 20:40:04 GMT

    [ https://issues.apache.org/jira/browse/HIVE-11934?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14938821#comment-14938821
] 

Eugene Koifman commented on HIVE-11934:
---------------------------------------

yes, I understand.  checkRetryable() is the main method that handles some checking itself
and delegates some checking to isRetryable().  it should be refactored at some point but the
fact is that ORA-8177 is checked for already.  This is not the cause of the infinite loop.

> Transaction lock retry logic results in infinite loop
> -----------------------------------------------------
>
>                 Key: HIVE-11934
>                 URL: https://issues.apache.org/jira/browse/HIVE-11934
>             Project: Hive
>          Issue Type: Bug
>          Components: HiveServer2, Transactions
>    Affects Versions: 1.2.1
>            Reporter: Steve Howard
>            Assignee: Eugene Koifman
>            Priority: Minor
>         Attachments: HIVE-11934.patch
>
>
> We reset the deadlock count to 0 every time the lock() method is called in org.apache.hadoop.hive.metastore.txn.TxnHandler,
so the ten count is never reached in checkRetryable().
> We should let checkRetryable handle the deadlock count.
>   public LockResponse lock(LockRequest rqst)
>     throws NoSuchTxnException, TxnAbortedException, MetaException
>   {
> >>>    this.deadlockCnt = 0; <<<
>     try
>     {
>       Connection dbConn = null;
>       try
>       {



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message