hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Szehon Ho (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-11903) Add zookeeper metrics to HS2
Date Thu, 24 Sep 2015 18:09:04 GMT

    [ https://issues.apache.org/jira/browse/HIVE-11903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14906753#comment-14906753
] 

Szehon Ho commented on HIVE-11903:
----------------------------------

Thanks, really appreciate this great improvement.   Some suggestions.

1.  Let's remove the JDBC zookeeper, as we are not expecting the client-side to have metrics,
just HS2 and HMS.
2.  Please put null checks around the metrics instance like you did in one of the places,
it will be null if metrics is not instantiated.
2.  Can we have also add additional metrics based on lock-types, ie exclusive, shared, etc?
3.  Can we add a test for metrics of number of locks?

> Add zookeeper metrics to HS2
> ----------------------------
>
>                 Key: HIVE-11903
>                 URL: https://issues.apache.org/jira/browse/HIVE-11903
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Diagnosability
>            Reporter: Szehon Ho
>            Assignee: Yongzhi Chen
>             Fix For: 1.3.0, 2.0.0
>
>         Attachments: HIVE-11903.1.patch
>
>
> Potential metrics are active zookeeper connections, locks taken by type, etc.  Can refine
as we go along.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message