hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Angus Smithson (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HIVE-11748) HivePreparedStatement's setTimestamp() does not quote value as required
Date Sun, 06 Sep 2015 15:31:45 GMT

     [ https://issues.apache.org/jira/browse/HIVE-11748?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Angus Smithson updated HIVE-11748:
----------------------------------
    Attachment: HIVE-11748.patch

Attaching HIVE-11748.patch.  This is similar to the changes under HIVE-11024, which fixed
the same bug in setDate().  It simply quotes the value of Timestamp.toString().
{noformat}
diff --git jdbc/src/java/org/apache/hive/jdbc/HivePreparedStatement.java jdbc/src/java/org/apache/hive/jdbc/HivePreparedStatement.java
index 7687537..81c3d5d 100644
--- jdbc/src/java/org/apache/hive/jdbc/HivePreparedStatement.java
+++ jdbc/src/java/org/apache/hive/jdbc/HivePreparedStatement.java
@@ -728,7 +728,7 @@ public void setTime(int parameterIndex, Time x, Calendar cal) throws SQLExceptio
    */
 
   public void setTimestamp(int parameterIndex, Timestamp x) throws SQLException {
-    this.parameters.put(parameterIndex, x.toString());
+    this.parameters.put(parameterIndex, "'" + x.toString() + "'");
   }
 
   /*
{noformat}

I've also added a unit test and some Dell SecureWorks license information to the NOTICE file.

> HivePreparedStatement's setTimestamp() does not quote value as required
> -----------------------------------------------------------------------
>
>                 Key: HIVE-11748
>                 URL: https://issues.apache.org/jira/browse/HIVE-11748
>             Project: Hive
>          Issue Type: Bug
>          Components: JDBC
>            Reporter: Angus Smithson
>         Attachments: HIVE-11748.patch
>
>
> [HivePreparedStatement.setTimestamp(int parameterIndex, Timestamp x)|https://hive.apache.org/javadocs/r1.2.1/api/org/apache/hive/jdbc/HivePreparedStatement.html#setTimestamp(int,%20java.sql.Timestamp)]
does not quote the Timestamp value when generating the HQL statement, resulting in a HiveSqlException
on execution.
> h5. Reproducing
> If we add the following unit test to {{itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java}}:
> {code}
>   @Test
>   public void testPrepareSetTimestamp() throws SQLException, ParseException {
>     String sql = String.format("SELECT * FROM %s WHERE c20 = ?", dataTypeTableName);
>     try (PreparedStatement ps = con.prepareStatement(sql)) {
>       Timestamp timestamp = new Timestamp(new SimpleDateFormat("yyyy-MM-dd").parse("2013-01-01").getTime());
>       ps.setTimestamp(1, timestamp);
>       try (ResultSet resultSet = ps.executeQuery()) {
>         assertTrue(resultSet.next());
>         assertEquals("2013-01-01", resultSet.getString(20));
>       }
>     }
>   }
> {code}
> The test fails:
> {noformat}
> org.apache.hive.service.cli.HiveSQLException: Error while compiling statement: FAILED:
ParseException line 1:55 cannot recognize input near '00' ':' '00' in expression specification
>   at org.apache.hadoop.hive.ql.parse.ParseDriver.parse(ParseDriver.java:205)
>   at org.apache.hadoop.hive.ql.parse.ParseDriver.parse(ParseDriver.java:166)
> 	at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:401)
> 	at org.apache.hadoop.hive.ql.Driver.compile(Driver.java:310)
> 	at org.apache.hadoop.hive.ql.Driver.compileInternal(Driver.java:1150)
> 	at org.apache.hadoop.hive.ql.Driver.compileAndRespond(Driver.java:1136)
> 	at org.apache.hive.service.cli.operation.SQLOperation.prepare(SQLOperation.java:109)
> 	at org.apache.hive.service.cli.operation.SQLOperation.runInternal(SQLOperation.java:180)
> 	at org.apache.hive.service.cli.operation.Operation.run(Operation.java:257)
> 	at org.apache.hive.service.cli.session.HiveSessionImpl.executeStatementInternal(HiveSessionImpl.java:405)
> 	at org.apache.hive.service.cli.session.HiveSessionImpl.executeStatementAsync(HiveSessionImpl.java:392)
> 	at org.apache.hive.service.cli.CLIService.executeStatementAsync(CLIService.java:261)
> 	at org.apache.hive.service.cli.thrift.ThriftCLIService.ExecuteStatement(ThriftCLIService.java:509)
> 	at sun.reflect.GeneratedMethodAccessor15.invoke(Unknown Source)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:606)
> 	at org.apache.hive.jdbc.HiveConnection$SynchronizedHandler.invoke(HiveConnection.java:1400)
> 	at com.sun.proxy.$Proxy32.ExecuteStatement(Unknown Source)
> 	at org.apache.hive.jdbc.HiveStatement.execute(HiveStatement.java:246)
> 	at org.apache.hive.jdbc.HiveStatement.executeQuery(HiveStatement.java:378)
> 	at org.apache.hive.jdbc.HivePreparedStatement.executeQuery(HivePreparedStatement.java:109)
> 	at org.apache.hive.jdbc.TestJdbcDriver2.testPrepareSetTimestamp(TestJdbcDriver2.java:2395)
> {noformat}
> The failure is because the following HQL is generated/executed by calling toString()
on the Timestamp value:
> {noformat}
> SELECT * FROM %s WHERE c20 = 2013-01-01 00:00:00.0
> {noformat}
> We should be quoting the value of Timestamp.toString(), so that the following HQL is
generated/executed:
> {noformat}
> SELECT * FROM %s WHERE c20 = '2013-01-01 00:00:00.0'
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message