hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Prasanth Jayachandran (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-11553) use basic file metadata cache in ETLSplitStrategy-related paths
Date Mon, 21 Sep 2015 20:28:04 GMT

    [ https://issues.apache.org/jira/browse/HIVE-11553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14901328#comment-14901328
] 

Prasanth Jayachandran commented on HIVE-11553:
----------------------------------------------

More comments:
1) // TODO: is this really needed? Shouldn't this be set already?.. I don't think so. Only
fileMetaInfo can change based on this config HIVE_ORC_INCLUDE_FILE_FOOTER_IN_SPLITS. metadata,types
and writerVersion shouldn't change. Can you remove it?
2) What is happening in catch block for createFileInfoFromMs()? If the bytebuffer is corrupted
for some reason why not just throw it away,invalidate cache and read it from file (and cache
it again)?
3) Why do we need to duplicate the buffer in createFileInfoFromMs()?
4) Also remove the temporary method makeLongKey() if point 2) is addressed?


> use basic file metadata cache in ETLSplitStrategy-related paths
> ---------------------------------------------------------------
>
>                 Key: HIVE-11553
>                 URL: https://issues.apache.org/jira/browse/HIVE-11553
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Sergey Shelukhin
>            Assignee: Sergey Shelukhin
>             Fix For: hbase-metastore-branch
>
>         Attachments: HIVE-11553.01.patch, HIVE-11553.02.patch, HIVE-11553.patch
>
>
> NO PRECOMMIT TESTS



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message