Return-Path: X-Original-To: apmail-hive-issues-archive@minotaur.apache.org Delivered-To: apmail-hive-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 656641815F for ; Wed, 12 Aug 2015 14:46:55 +0000 (UTC) Received: (qmail 1334 invoked by uid 500); 12 Aug 2015 14:46:45 -0000 Delivered-To: apmail-hive-issues-archive@hive.apache.org Received: (qmail 1310 invoked by uid 500); 12 Aug 2015 14:46:45 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 1300 invoked by uid 99); 12 Aug 2015 14:46:45 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 12 Aug 2015 14:46:45 +0000 Date: Wed, 12 Aug 2015 14:46:45 +0000 (UTC) From: "Alan Gates (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-11483) Add encoding and decoding for query string config MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-11483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693611#comment-14693611 ] Alan Gates commented on HIVE-11483: ----------------------------------- bq. How do we distinguish between actual ^A with control-A ? And how to decode them back I was assuming the query was for human consumption only. I like URL encoding as there is tool support for it and it's reasonably human readable. bq. I think this should not break the existing behaviour Agreed, but does any current Hive behavior depend on this? Or are you worried about external tools depending on it? > Add encoding and decoding for query string config > ------------------------------------------------- > > Key: HIVE-11483 > URL: https://issues.apache.org/jira/browse/HIVE-11483 > Project: Hive > Issue Type: Improvement > Components: Query Processor > Reporter: Amareshwari Sriramadasu > Assignee: Akshay Goyal > > We have seen some queries in production where some of the literals passed in the query have control characters, which result in exception when query string is set in the job xml. > Proposing a solution to encode the query string in configuration and provide getters decoded string. > Here is a commit in a forked repo : https://github.com/InMobi/hive/commit/2faf5761191fa3103a0d779fde584d494ed75bf5 > Suggestions are welcome on the solution. -- This message was sent by Atlassian JIRA (v6.3.4#6332)