Return-Path: X-Original-To: apmail-hive-issues-archive@minotaur.apache.org Delivered-To: apmail-hive-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id CEB071847D for ; Mon, 24 Aug 2015 22:37:45 +0000 (UTC) Received: (qmail 76202 invoked by uid 500); 24 Aug 2015 22:37:45 -0000 Delivered-To: apmail-hive-issues-archive@hive.apache.org Received: (qmail 76175 invoked by uid 500); 24 Aug 2015 22:37:45 -0000 Mailing-List: contact issues-help@hive.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@hive.apache.org Delivered-To: mailing list issues@hive.apache.org Received: (qmail 76164 invoked by uid 99); 24 Aug 2015 22:37:45 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 24 Aug 2015 22:37:45 +0000 Date: Mon, 24 Aug 2015 22:37:45 +0000 (UTC) From: "Lars Francke (JIRA)" To: issues@hive.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (HIVE-8007) Clean up Thrift definitions MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HIVE-8007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14710182#comment-14710182 ] Lars Francke commented on HIVE-8007: ------------------------------------ Oh...no... I did not regenerate the files as I could not get Thrift to build :( At least I was correct about the build failure being unrelated ;-) I'll try again to get Thrift working, thanks for the heads up! > Clean up Thrift definitions > --------------------------- > > Key: HIVE-8007 > URL: https://issues.apache.org/jira/browse/HIVE-8007 > Project: Hive > Issue Type: Improvement > Reporter: Lars Francke > Assignee: Lars Francke > Priority: Minor > Attachments: HIVE-8007.1.patch, HIVE-8007.2.patch, HIVE-8007.3.patch > > > This patch changes the following: > * Currently the thrift file uses {{//}} to denote comments. Thrift understands the {{/** ... */}} syntax and converts that into documentation in the generated code. This patch changes the syntax > * Change tabs to spaces > * Consistent indentation > * Minor whitespace and/or formatting issues > There should be no changes to functionality at all. -- This message was sent by Atlassian JIRA (v6.3.4#6332)