hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hive QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-11638) ExprNodeDesc hashMap accidentally degrades into O(N) instead of O(1)
Date Tue, 25 Aug 2015 19:52:45 GMT

    [ https://issues.apache.org/jira/browse/HIVE-11638?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14711854#comment-14711854
] 

Hive QA commented on HIVE-11638:
--------------------------------



{color:red}Overall{color}: -1 at least one tests failed

Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12752154/HIVE-11638.1.patch

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 9377 tests executed
*Failed tests:*
{noformat}
org.apache.hive.hcatalog.api.TestHCatClient.testTableSchemaPropagation
{noformat}

Test results: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5064/testReport
Console output: http://ec2-174-129-184-35.compute-1.amazonaws.com/jenkins/job/PreCommit-HIVE-TRUNK-Build/5064/console
Test logs: http://ec2-174-129-184-35.compute-1.amazonaws.com/logs/PreCommit-HIVE-TRUNK-Build-5064/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12752154 - PreCommit-HIVE-TRUNK-Build

> ExprNodeDesc hashMap accidentally degrades into O(N) instead of O(1)
> --------------------------------------------------------------------
>
>                 Key: HIVE-11638
>                 URL: https://issues.apache.org/jira/browse/HIVE-11638
>             Project: Hive
>          Issue Type: Improvement
>          Components: Logical Optimizer
>    Affects Versions: 0.14.0, 1.0.1, 1.1.1, 1.3.0, 1.2.1, 2.0.0
>            Reporter: Gopal V
>            Assignee: Gopal V
>              Labels: Performance
>         Attachments: HIVE-11638.1.patch
>
>
> Due to the absence of ExprNodeDesc::equals() & the presence of a hashCode(), any
code which computes a Set or HashMap of identical objects ends up with a skewed hashmap which
degrades column lookups from O(1) to O(N) during optimizer passes.
> So, several hundred references to a single column desc will be stored in a single hashbucket,
but since they default to Object::equals(), they are not equal to each other.
> Finalize the equals() method, so that the approach from HIVE-10215 carries over safely.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message