hive-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dong Chen (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HIVE-11637) Support hive.cli.print.current.db in new CLI[beeline-cli branch]
Date Thu, 27 Aug 2015 02:42:45 GMT

    [ https://issues.apache.org/jira/browse/HIVE-11637?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14715975#comment-14715975
] 

Dong Chen commented on HIVE-11637:
----------------------------------

[~Ferd], thanks for the patch. It looks generally good, and the logic make sense to me.

I just have some minor comments:
* should {{ClientCommandHookFactory.instance}} be final?
* In {{UseCommandHook.postHook()}}, {{dbName = line.split(" ")\[1\];}} -> {{dbName = strs\[1\];}}
?
* Can you elaborate the javadoc of class {{ClientHook}} for understanding its purpose easier?
* keep the method {{verifyCMD}} in the test still private?

> Support hive.cli.print.current.db in new CLI[beeline-cli branch]
> ----------------------------------------------------------------
>
>                 Key: HIVE-11637
>                 URL: https://issues.apache.org/jira/browse/HIVE-11637
>             Project: Hive
>          Issue Type: Sub-task
>          Components: CLI
>            Reporter: Ferdinand Xu
>            Assignee: Ferdinand Xu
>         Attachments: HIVE-11637.1-beeline-cli.patch, HIVE-11637.2-beeline-cli.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message